Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address contract twins feature performance #3303

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Sep 18, 2020

#3236

Motivation

some pages of unverified contracts are not opened on tie due to long request for searching of verified contract twins

Changelog

Replace left join with inner join in the target query

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Sep 18, 2020

Pull Request Test Coverage Report for Build d59aac0decee0af4368f66653b8cfc3bd2c84518-PR-3303

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+4.4%) to 75.836%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 8e6c9cd96f8ff03e1e6561408a420e8d782eac81: 4.4%
Covered Lines: 1927
Relevant Lines: 2541

💛 - Coveralls

@vbaranov vbaranov merged commit 30525e5 into master Sep 19, 2020
@vbaranov vbaranov deleted the vb-contract-twins-performance branch September 19, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants