Fix bug with empty array in write contract page #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitosing
force-pushed
the
np-bug-with-empty-array
branch
from
ac961a6
to
daeb11c
Compare
vbaranov
reviewed
Jun 7, 2021
Comment on lines
36
to
38
| if (sanitizedInputValue === '') { | ||
| return [[]] | ||
| } |
There was a problem hiding this comment.
@nikitosing I would suggest defining this pattern in a separate function since the same construction is used above in this file.
nikitosing
force-pushed
the
np-bug-with-empty-array
branch
from
daeb11c
to
696dcc2
Compare
nikitosing
force-pushed
the
np-bug-with-empty-array
branch
from
696dcc2
to
3174415
Compare
vbaranov
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to resolve issue #4206
apps/block_scout_web/assets/js/lib/smart_contract/common_helpers.jsprepareMethodArgs()