Skip to content
This repository has been archived by the owner on Dec 31, 2019. It is now read-only.

Gnome-terminal on Fedora 25 #18

Closed
pjaleeuwen opened this issue Jun 9, 2017 · 2 comments · Fixed by atom/atom#20393
Closed

Gnome-terminal on Fedora 25 #18

pjaleeuwen opened this issue Jun 9, 2017 · 2 comments · Fixed by atom/atom#20393

Comments

@pjaleeuwen
Copy link

pjaleeuwen commented Jun 9, 2017 •
edited
Loading

Installing this package for Atom on Fedora 25 and changing the terminal to 'gnome-terminal' has an unexpected side effect. It opens the terminal in the correct location how I would expect, it however prints a few lines in that terminal:

bash: error importing function definition for `BASH_FUNC_module'
bash: scl: line 1: syntax error: unexpected end of file
bash: error importing function definition for `BASH_FUNC_scl'
/bin/sh: scl: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `BASH_FUNC_scl'
/bin/sh: module: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `BASH_FUNC_module'
/bin/sh: scl: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `BASH_FUNC_scl'
/bin/sh: module: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `BASH_FUNC_module'
/bin/sh: scl: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `BASH_FUNC_scl'
/bin/sh: module: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `BASH_FUNC_module'
[pjaleeuwen@localhost auth]$
@blueimp
Copy link
Owner

blueimp commented Jun 9, 2017

Not sure if this will help, but I found the following two possibly related issues:
AtomLinter/linter-puppet-lint#68
AtomLinter/linter-flake8#165

Could you try out the suggested fixes in those issue tickets and report back if that solved it?

@blueimp
Copy link
Owner

blueimp commented Mar 20, 2018

Closing as there was no response from @pjaleeuwen

@blueimp blueimp closed this as completed Mar 20, 2018
xdelaruelle added a commit to xdelaruelle/atom that referenced this issue Feb 8, 2020
@xdelaruelle
Skip shell functions when parsing env
3629f4a 
`getEnvFromShell` function calls `env` command through shell to get all
defined environment variable. However `env` also returns the shell
function defined with their whole code written on multiple lines.

Such shell function definitions were not properly handled by
`getEnvFromShell` which led to the following kind of error messages
(seen for instance when running a terminal package in Atom):

  bash: module: line 1: syntax error: unexpected end of file
  bash: error importing function definition for `BASH_FUNC_module'

With this change `getEnvFromShell` now skips shell function definition
to guarantee only environment variables are recorded and a sane `result`
array is returned.

Fixes atom#20389
Fixes atom#17369
Fixes atom#13451
Fixes blueimp/atom-open-terminal-here#27
Fixes blueimp/atom-open-terminal-here#18
Fixes bus-stop/Termination#101
Fixes bus-stop/terminus#24
Fixes platformio/platformio-atom-ide-terminal#120
Fixes platformio/platformio-atom-ide-terminal#293
Fixes AtomLinter/linter-pylint#243
Fixes AtomLinter/linter-flake8#643
Fixes AtomLinter/linter-flake8#165
Fixes AtomLinter/linter-flake8#422
Fixes AtomLinter/linter-puppet-lint#68
Fixes autocomplete-python/autocomplete-python#347
@xdelaruelle xdelaruelle mentioned this issue Feb 8, 2020
Merged
xdelaruelle added a commit to xdelaruelle/atom that referenced this issue Feb 8, 2020
@xdelaruelle
Skip shell functions when parsing env
1cc2f2d 
`getEnvFromShell` function calls `env` command through shell to get all
defined environment variable. However `env` also returns the shell
function defined with their whole code written on multiple lines.

Such shell function definitions were not properly handled by
`getEnvFromShell` which led to the following kind of error messages
(seen for instance when running a terminal package in Atom):

  bash: module: line 1: syntax error: unexpected end of file
  bash: error importing function definition for `BASH_FUNC_module'

With this change `getEnvFromShell` now skips shell function definition
to guarantee only environment variables are recorded and a sane `result`
array is returned.

Fixes atom#20389
Fixes atom#17369
Fixes atom#13451
Fixes blueimp/atom-open-terminal-here#27
Fixes blueimp/atom-open-terminal-here#18
Fixes bus-stop/Termination#101
Fixes bus-stop/terminus#24
Fixes platformio/platformio-atom-ide-terminal#120
Fixes platformio/platformio-atom-ide-terminal#293
Fixes AtomLinter/linter-pylint#243
Fixes AtomLinter/linter-flake8#643
Fixes AtomLinter/linter-flake8#165
Fixes AtomLinter/linter-flake8#422
Fixes AtomLinter/linter-puppet-lint#68
Fixes autocomplete-python/autocomplete-python#347
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip shell functions when parsing env xdelaruelle/atom
2 participants
@blueimp @pjaleeuwen