[WIP] React Native 0.70.0 Upgrade #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade React Native to 0.70.0Changes
ios/Podfileandios/app/AppDelegate.mmneeded some extra minor changes to fix building errors for iOSBLOCKERS⚠️ ⚠️
Support regex named capture groups facebook/hermes#696
and
[bug][ios] main.jsbundle Invalid regular expression: Quantifier has nothing to repeat facebook/react-native#32453
hermes does not support regex named capture groups. As such, the app throws a runtime error on
src/view/routes.tsline 35 regarding this issue.React Native upgrade will stay on hold until there is developments on these issues
Steps to clean build and run app after upgrade
sudo gem install cocoapodsrm -rf node_modulesyarn installcd ios && pod deintegrate && pod install