Switch to blosc2; add Python 3.12 support #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
force-pushed
the
blosc2-py312
branch
from
61df740
to
1ae39ce
Compare
Looks good, as advertised 👍 |
danielballan
commented
Apr 19, 2024
| if modules_available("blosc"): | ||
| import blosc | ||
|
|
||
| # The choice of settings here is cribbed from distributed.protocol.compression. |
There was a problem hiding this comment.
I cargo-culted these settings from dask.distributed in the first place without any benchmarking. They aren't directly transferrable to blsoc2, so I have reverted to just going with the defaults for now until we have time to benchmark.
There was a problem hiding this comment.
Do you want to retain this TODO as a comment or as a low-priority github issue?
There was a problem hiding this comment.
Good call. Done #724
hyperrealist
approved these changes
Apr 22, 2024
| if modules_available("blosc"): | ||
| import blosc | ||
|
|
||
| # The choice of settings here is cribbed from distributed.protocol.compression. |
There was a problem hiding this comment.
Do you want to retain this TODO as a comment or as a low-priority github issue?
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library blosc2 is evidently superseding blosc, which has not published a release since 2022 and has yet to publish Python 3.12-compatible wheels. This is blocking Tiled support for Python 3.12.
Blosc2 claims to be fully backward-compatible with Blosc1-serialized bytes. I'd like to verify that old tiled clients can talk to new tiled servers before we merge.
As an aside, while looking into this I noticed that
distributeddropped support for blosc. Someday it would be good to evaluate how much value we are deriving from this dependency, but I'm inclined to keep it for now.