Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed FluentNumber parsing crashing on non-US locales #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Fluent.Net/MessageContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,13 @@ public override bool Match(MessageContext ctx, object other)

public class FluentNumber : FluentType
{
double _numberValue;
readonly double _numberValue;

public FluentNumber(string value) :
base(value)
{
_numberValue = Double.Parse(value);
if (double.TryParse(value, NumberStyles.Any, NumberFormatInfo.InvariantInfo, out var numberValue))
_numberValue = numberValue;
}

public override string Format(MessageContext ctx)
Expand Down