Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: skip checking state root existence when do snapsync by fast node #2258

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Mar 6, 2024

Description

fast node doesn't have a state merkle trie

and when do inited snap sync, Snapshot maintenance disabled

so if !bc.HasState(root) always return true

To solve this ,skip checking state root existence when do snapsync by fast node

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as draft March 6, 2024 08:16
@buddh0 buddh0 marked this pull request as ready for review March 6, 2024 08:21
@buddh0 buddh0 merged commit b75720d into bnb-chain:develop Mar 7, 2024
7 checks passed
@buddh0 buddh0 deleted the fast_node_skip_checking branch March 11, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants