Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix devnet after 1.7.2 upstream merge #194

Merged
merged 4 commits into from
May 13, 2024

Conversation

welkin22
Copy link
Contributor

@welkin22 welkin22 commented May 8, 2024

Description

After merging the code from upstream version 1.7.2, we need to make some modifications to ensure that our Devnet scripts continue to function properly. Among them, we need to test the ability to submit blobs for BSC as L1, so I have made significant changes to the Devnet deployment process for BSC.

Rationale

After merging upstream code, fix our Devnet script.

Example

After this PR, you can still use the make devnet-up command to start Devnet. For more details, please refer to the content of the bedrock-devnet/README.md file.

Changes

Notable changes:

  • Fix Devnet script

Copy link
Contributor

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@welkin22 welkin22 merged commit 0b40e25 into bnb-chain:develop May 13, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants