Kotlin 1.8.20 #89
Kotlin 1.8.20 #89
Conversation
|
Tip: change base to #86's branch, so the diff is clear. |
| @@ -46,7 +46,7 @@ fun compile( | |||
| // black hole all writes | |||
| } | |||
| } | |||
| compilerPlugins = plugins.toList() | |||
| this.componentRegistrars = componentRegistrars.toList() | |||
There was a problem hiding this comment.
If this is the only breaking change, this can be supported both ways with trivial reflection, @bnorm?
There was a problem hiding this comment.
this is only in the test sources, so that change would not matter.
I think it cannot work with 1.8.20 and 1.7 because the kotlin compiler apis that it compiles against are different.
There was a problem hiding this comment.
If that's the case, could the repo be updated to Kotlin Gradle Plugin 1.8, but keep the kotlinOptions.languageVersion and apiVersion at 1.7? This normally works with standard jars, not sure if a compiler plugin is different.
Oh interesting I did not know that thats possible. Can I change it without recreating the pr? will that also change where a merge would go to? Anyway for this pr all the important changes are in one commit. |
This comment was marked as off-topic.
This comment was marked as off-topic.
that does not work because it shows only branches in the main repo, and the kotlinter branch is in my fork of the repo.
really? IMO all commits that matter are in the "Kotlin 1.8.2" commit, except for the build script linting which is unrelated to the kotlin change |
This comment was marked as off-topic.
This comment was marked as off-topic.
yeah, thanks! |
christophsturm
force-pushed
the
kotlin-1.8
branch
from
5804b15
to
bcc8139
Compare
|
Woot! Thank you! |
a more compact pr to fix the build on kotlin 1.8.20. based on #86