Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorStrip mouse click => navigation issue #496

Closed
DrDaleks opened this issue Feb 24, 2023 · 1 comment
Closed

ErrorStrip mouse click => navigation issue #496

DrDaleks opened this issue Feb 24, 2023 · 1 comment
Labels
Milestone

Comments

@DrDaleks
Copy link
Contributor

Description
Clicking in the error strip does not browse to the proper document location. The error strip should represent the full document, independently of its actual size in the viewport, but it seems the calculation back from error strip's mouse click position to document location is incorrect.

Steps to Reproduce
Specific steps to reproduce the behavior:

  1. Fire up a TextEditorPane with an ErrorStrip on its side (right side in my case)
  2. Load a document that is larger than the current viewport
  3. Click on the error strip to navigate (preferably near the bottom to maximise the effect)

NB: this issue does not apply to markers.

Expected behavior
Navigating to the proper location (bottom of error strip should show bottom of document)

Actual behavior
The caret moves indeed but seems to remain close to the top of the document

Java version
LibericaVM-17

Additional context
This issue does not apply to markers and seems to be related to the calculation in ErrorStrip.yToLine(int) method

@DrDaleks DrDaleks added the bug label Feb 24, 2023
@DrDaleks DrDaleks changed the title ErrorStrip mouse click => wrong behaviour ErrorStrip mouse click => navigation issue Feb 24, 2023
DrDaleks added a commit to DrDaleks/RSyntaxTextArea that referenced this issue Feb 24, 2023
Fixing document navigation on mouse click outside of a marker (see bobbylight#496)
bobbylight pushed a commit that referenced this issue Feb 25, 2023
Fixing document navigation on mouse click outside of a marker (see #496)
@bobbylight
Copy link
Owner

Fixed in linked PR #497. Thanks again!

@bobbylight bobbylight added this to the 3.3.3 milestone Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants