Python autoindent support and fix to Python Fold Parser #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I did not add or update any tests. I'm not quite familiar enough with RSyntaxTextArea to determine if/where they should be added. I am happy to add tests as may be appropriate. |
awindillman
changed the title
|
This PR will also close the bug noted in issue #512 |
bobbylight
requested changes
Jul 9, 2023
RSyntaxTextArea/src/test/java/org/fife/ui/rsyntaxtextarea/folding/PythonFoldParserTest.java
Show resolved
Hide resolved
RSyntaxTextArea/src/main/java/org/fife/ui/rsyntaxtextarea/modes/PythonTokenMaker.java
Show resolved
Hide resolved
| if (t!=null && t.length()==1) { | ||
| ch = t.charAt(0); | ||
| } | ||
| return ch=='\\'; |
There was a problem hiding this comment.
This can be made a little simpler with isSingleChar:
t != null && t.isSingleChar('\\')There was a problem hiding this comment.
OK. Will commit with other changes.
RSyntaxTextArea/src/main/java/org/fife/ui/rsyntaxtextarea/folding/PythonFoldParser.java
Show resolved
Hide resolved
|
Thanks for the review. (Vaguely related: Looking forward to adding code completion for Jython when I get some time.) |
bobbylight
approved these changes
Jul 26, 2023
|
Thanks for the PR! |
This was referenced Jul 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close the small enhancement requested in issue #507