Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parameter passed to ApproveAndCallFallBack() function #5

Closed
bokkypoobah opened this issue Feb 8, 2018 · 0 comments
Closed

Comments

@bokkypoobah
Copy link
Owner

bokkypoobah commented Feb 8, 2018

From oleksii's audit:

ApproveAndCallFallBack(spender).receiveApproval(msg.sender, tokens, tokenContract, data);
msg,sender used instead of tokenOwner. <<<<< MAJOR >>>>>

The main impact from this issue is that the signedApproveAndCall(...) functionality will not work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant