Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow exception from VisualizerMapping with second VisualizerMapping as input #1769

Closed
RoboDoig opened this issue May 2, 2024 · 1 comment · Fixed by #1787
Closed
Labels
bug Something isn't working
Milestone

Comments

@RoboDoig
Copy link

RoboDoig commented May 2, 2024

While investigating #1591 I noticed that creating this workflow is possible in the editor:

image

When run this results in a terminating crash from a stack overflow exception, presumably due to a cyclical dependency.

@glopesdev glopesdev added the bug Something isn't working label May 4, 2024
@glopesdev glopesdev added this to the 2.8.3 milestone May 4, 2024
@RoboDoig
Copy link
Author

RoboDoig commented May 8, 2024

Looked into this a bit more, the issue comes from entering an infinite recursive call in LayoutHelper.GetMashupArguments. For example in this case, the Int mapping source argument will be passed on every recursive call.

I can't think of any situation where you would want to combine visualizers as in the workflow example above as the information is redundant. In that case the fix may be just to disallow visualizer combinations where the data source is the same for visualizers in the combination.

PathogenDavid added a commit to PathogenDavid/bonsai that referenced this issue May 10, 2024
PathogenDavid added a commit to PathogenDavid/bonsai that referenced this issue May 10, 2024
PathogenDavid added a commit to PathogenDavid/bonsai that referenced this issue May 14, 2024
PathogenDavid added a commit to PathogenDavid/bonsai that referenced this issue May 15, 2024
PathogenDavid added a commit to PathogenDavid/bonsai that referenced this issue May 15, 2024
PathogenDavid added a commit to PathogenDavid/bonsai that referenced this issue May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants