Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forecast visualizers #13

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Conversation

ncguilbeault
Copy link
Collaborator

@ncguilbeault ncguilbeault commented May 10, 2024

Summary

This PR adds support for visualizing forecasts. This adds both a base visualizer called ForecastVisualizer, as well as mashup visualizers to observe the forecast in relation to the KinematicState timeseries plot ForecastPlotOverlay and an image being tracked ForecastImageOverlay.

@glopesdev glopesdev self-requested a review May 17, 2024 10:13
@glopesdev glopesdev added the feature New planned feature label May 17, 2024
@ncguilbeault
Copy link
Collaborator Author

ncguilbeault commented May 22, 2024

I've updated the ForecastVisualizer to inherit BufferedVisualizer now.

I also realize that the PR doesnt build with the new CI workflow because of dependencies with types in #11. Once we rebase this PR to that one, it should build successfully.

@ncguilbeault ncguilbeault force-pushed the lds-forecast-mashup-visualizers branch from 8799ce1 to 417bf34 Compare June 4, 2024 12:33
@glopesdev glopesdev merged commit aeb9c45 into main Jun 4, 2024
2 checks passed
@glopesdev glopesdev deleted the lds-forecast-mashup-visualizers branch June 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants