Refactor LDS Package #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
approved these changes
Sep 23, 2024
ncguilbeault
force-pushed
the
lds-refactor
branch
from
944b3fd
to
32555e8
Compare
glopesdev
approved these changes
Sep 23, 2024
Yes, that's the idea. I imagine we will use this class when we start integrating models directly in C#, but for right now, it is only being used to refer to named python objects inside of the python runtime engine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the Bonsai.ML.LinearDynamicalSystems (LDS) package to use the newly formed Bonsai.ML, Bonsai.ML.Python, and Bonsai.ML.Data packages introduced in #22 . This PR also adds XML comments to previously undocumented functions within the package.