Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sign in sign up action #105

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Conversation

jinwoong16
Copy link
Collaborator

๐Ÿ“• Issue Number

Close #104

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • ๋กœ๊ทธ์ธ ์„ฑ๊ณต์‹œ, ํ™”๋ฉด์„ Pop
  • ํšŒ์›๊ฐ€์ž… ์„ฑ๊ณต์‹œ, ํ™”๋ฉด์„ popToRoot
  • ๋กœ๊ทธ์ธ๊ณผ ํšŒ์›๊ฐ€์ž… ์‹คํŒจ์‹œ, alert์ฐฝ ๋„์›Œ์คŒ

  • ์ค‘๋ณต๋˜๋Š” ์ด๋ฉ”์ผ๋กœ ์ธํ•ด ํšŒ์›๊ฐ€์ž… ์‹คํŒจ

  • ๋ฌธ์ œ์—†์œผ๋ฉด ํšŒ์›๊ฐ€์ž… ์„ฑ๊ณต, ์ฒ˜์Œ ๋ทฐ๋กœ ๋Œ์•„๊ฐ

  • ๋กœ๊ทธ์ธ ์‹คํŒจ์‹œ, alert๋ฅผ, ์„ฑ๊ณตํ•˜๋ฉด view๋ฅผ pop

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?
  • ์ƒˆ๋กœ์šด ํ…Œ์ŠคํŠธ์™€ ๊ธฐ์กด์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์— ๋Œ€ํ•ด ๋งŒ์กฑํ•˜๋Š”๊ฐ€?

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

    func signUp(email: String, password: String, userDto: UserDTO) -> Single<Bool> {
       ...
            self.auth.createUser(withEmail: email, password: password) { authResult, error in
                do {
                    if let error = error { throw error }
                    guard let authResult = authResult else { throw NetworkServiceError.noAuthError }
                    try self.createUser(uuid: authResult.user.uid, userDto: userDto)

                   /** ์ด๋ถ€๋ถ„ ์ถ”๊ฐ€! */
                    self.uid.accept(self.auth.currentUser?.uid)

                    single(.success(true))
                } catch let error {
                    single(.failure(error))
                }
        ....
    }
  • ํŒŒ์ด์–ด๋ฒ ์ด์Šค๋Š” ํšŒ์›๊ฐ€์ž… ์„ฑ๊ณตํ•˜๋ฉด, ๋ฐ”๋กœ ๋กœ๊ทธ์ธ ์ฒ˜๋ฆฌ๋ฉ๋‹ˆ๋‹ค!! ์ด๋กœ ์ธํ•ด์„œ, Data์˜ FirebaseService์˜ ํšŒ์›๊ฐ€์ž… ๋กœ์ง์— ๋‹ค์Œ๋ถ€๋ถ„์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.



@sprituz
Copy link
Member

sprituz commented Dec 7, 2022

์•„์ฃผ ์ข‹์Šต๋‹ˆ๋‹ค

1 similar comment
@Jeonhui
Copy link
Member

Jeonhui commented Dec 7, 2022

์•„์ฃผ ์ข‹์Šต๋‹ˆ๋‹ค

@jinwoong16 jinwoong16 merged commit d9dd032 into develop Dec 8, 2022
@jinwoong16 jinwoong16 deleted the feature/SignInSignUpAction branch December 8, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignInSignUp Action
3 participants