Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/repository #108

Merged
merged 7 commits into from
Dec 8, 2022
Merged

Refactor/repository #108

merged 7 commits into from
Dec 8, 2022

Conversation

Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Dec 7, 2022

๐Ÿ“• Issue Number

Close #106

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • signUp ํ€˜์ŠคํŠธ ๋„คํŠธ์›Œํฌ์—์„œ ํŒจ์น˜
  • signOut ํ€˜์ŠคํŠธ ๋กœ์ปฌ ๋ฐ์ดํ„ฐ ์‚ญ์ œ

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?
  • ์ƒˆ๋กœ์šด ํ…Œ์ŠคํŠธ์™€ ๊ธฐ์กด์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์— ๋Œ€ํ•ด ๋งŒ์กฑํ•˜๋Š”๊ฐ€?

์‹คํ–‰ ์ „

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2022-12-07 21 06 48

๋กœ๊ทธ์ธ ํ›„

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2022-12-07 21 07 18

๋กœ๊ทธ์•„์›ƒ ํ›„

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2022-12-07 21 07 57

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

  • ๋กœ๊ทธ์ธ, ๋กœ๊ทธ์•„์›ƒํ•œ ๋’ค ํ™ˆ๋ทฐ ๋ฆฌ๋กœ๋”ฉ



@jinwoong16
Copy link
Collaborator

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค. ๊ทผ๋ฐ ์ „ํฌ๋‹˜ ์—๋””ํ„ฐ๊ฐ€ ์ธ๋ดํŠธ๋ฅผ ์ด์ƒํ•˜๊ฒŒ ๋จน์ด๋Š” ๊ฒƒ ๊ฐ™๋„ค์š”..? ๐Ÿ˜ข

@jinwoong16 jinwoong16 merged commit 495d787 into develop Dec 8, 2022
@Jeonhui Jeonhui deleted the refactor/Repository branch December 8, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignInSignUp Quest Fetch ์ž‘์—…
2 participants