Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/home view #115

Merged
merged 16 commits into from
Dec 8, 2022
Merged

Feature/home view #115

merged 16 commits into from
Dec 8, 2022

Conversation

Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Dec 7, 2022

๐Ÿ“• Issue Number

Close #114

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ ๋ฒ„ํŠผ ํด๋ฆญ ์ด๋ฒคํŠธ
  • ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ ๊ฐ€์ ธ์˜ค๊ธฐ
  • ๋กœ๊ทธ์ธ ๋กœ๊ทธ์•„์›ƒ์‹œ ๋ฆฌ๋กœ๋”ฉ
  • ๋งฅ์Šค ํ„ฐ์น˜์‹œ ๋ฉ”์„ธ์ง€ ๋ณ€๊ฒฝ

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?
  • ์ƒˆ๋กœ์šด ํ…Œ์ŠคํŠธ์™€ ๊ธฐ์กด์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์— ๋Œ€ํ•ด ๋งŒ์กฑํ•˜๋Š”๊ฐ€?

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

  • ์ด๋ฏธ์ง€๋ฅผ ๊ฐ€์ ธ์˜ฌ ๋•Œ ํด๋ฆญ์‹œ ์ด๋ฏธ์ง€๊ฐ€ ๋˜๋Œ์•„์˜ค๋Š”๋ฐ ํ•ด๊ฒฐ ๋ฐฉ๋ฒ•?
  • quest cell์ด ๋ณ€๊ฒฝ๋˜๋Š” ์กฐ๊ฑด์— ์ถ”๊ฐ€ํ•˜์—ฌ ๊ฐœ๋ฐœ์„ ํ•˜์˜€๋Š”๋ฐ ๋‹ค๋ฅธ ๋ทฐ๋“ค๋„ ๋ฆฌ๋กœ๋”ฉ์ด ๋˜๋Š”์ง€?



@jinwoong16 jinwoong16 merged commit 52a4e27 into develop Dec 8, 2022
@Jeonhui Jeonhui deleted the feature/HomeView branch December 8, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

homeView ๋ฆฌํŽ™ํ† ๋ง
3 participants