Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/data & SyncManager #127

Merged
merged 34 commits into from
Dec 9, 2022
Merged

Refactor/data & SyncManager #127

merged 34 commits into from
Dec 9, 2022

Conversation

Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Dec 8, 2022

๐Ÿ“• Issue Number

Close #126

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • user ์ด๋ฏธ์ง€ ๋ณ€๊ฒฝ์‹œ ๋…ธํ‹ฐ
  • ํ”„๋กœํ•„ ๋ฒ„ํŠผ aspectFill
  • NetworkService Protocol ๋ณ€๊ฒฝ
  • user ์ด๋ฏธ์ง€ ๋ณ€๊ฒฝ์‹œ ํŒŒ์ด์–ด์Šคํ† ์–ด ์ด์ „ ๋ฐ์ดํ„ฐ ์‚ญ์ œ
  • ์—๋Ÿฌ ํ•ธ๋“ค๋ง
  • observable -> Single๋กœ ๋ณ€๊ฒฝ
  • quest Equatable ์ƒ์†
  • SyncManager ๊ตฌํ˜„

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?
  • ์ƒˆ๋กœ์šด ํ…Œ์ŠคํŠธ์™€ ๊ธฐ์กด์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์— ๋Œ€ํ•ด ๋งŒ์กฑํ•˜๋Š”๊ฐ€?

Quest ์ถ”๊ฐ€

-> ๋กœ๊ทธ์ธ (Firebase์— ์ €์žฅ๋˜์ง€ ์•Š์€ ํ€˜์ŠคํŠธ ์กด์žฌ(์œ„ ๋กœ๊ทธ์ธ ์ „ ์ถ”๊ฐ€ํ•œ ํ€˜์ŠคํŠธ))

๊ฒฐ๊ณผ

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2022-12-09 02 55 50

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2022-12-09 02 57 50

์‹ค์ œ ๋””๋ฐ”์ด์Šค ํ…Œ์ŠคํŠธ (Xcode ๋นŒ๋“œX)

Quest ์ถ”๊ฐ€

๋กœ๊ทธ์ธ

๊ฒฐ๊ณผ

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

  • Sync Manager ์ •์ƒ ๋™์ž‘ (ํ…Œ์ŠคํŠธ ์™„)



jinwoong16 and others added 25 commits December 8, 2022 21:00
@Jeonhui Jeonhui self-assigned this Dec 8, 2022
@jinwoong16 jinwoong16 merged commit 7fe3512 into develop Dec 9, 2022
@jinwoong16 jinwoong16 deleted the refactor/userUseCase branch December 9, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync Manager
3 participants