-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/realm #13
Feature/realm #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
κ³ μνμ
¨μ΄μ~
μ λ λΉ λ₯Έ μμΌλ΄μ DB 곡λΆν΄μ λ μλ³Ό μ μκ² ν κ²μ :)
@@ -8,16 +8,16 @@ | |||
import Foundation | |||
import RealmSwift | |||
|
|||
class UserQuestEntity: Object { | |||
final class UserQuestEntity: Object { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final ν€μλλ‘ μ±λ₯ν₯μ μ’μμ ~ :)
@@ -9,16 +9,18 @@ import Foundation | |||
|
|||
extension BrowseQuestEntity { | |||
convenience init(browseQuest: BrowseQuest) { | |||
let questsEntities = browseQuest.quests.compactMap { UserQuestEntity(quest: $0) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ΄λ κ²λ μ¬μ©ν μ μμ΅λλ€!
let questsEntities = browseQuest.quests.compactMap { UserQuestEntity(quest: $0) } | |
let questsEntities = browseQuest.quests.compactMap(UserQuestEntity(quest:)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ§μ λμ΄ μλ €μ£Όμ λ°©λ²μ΄ λ κΉλν΄λ³΄μ΄λ€μ 리ν©ν λ§ λΈλμΉνμ Assertionμ΄λ κ°μ΄ κ³ μ³λ³΄κ² μ΅λλ€
guard let realmStorage = self?.realmStorage else { | ||
return Disposables.create() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertion μλ¬λ₯Ό λμμ£Όλ©΄ μ’μ κ² κ°μ΅λλ€. λΉλ‘ μ±μ΄ μ£½μ§λ§, κ°λ°νλ λμμλ νμ€ν indicateλ₯Ό λ°μ μ μμ κ² κ°μμ :)
guard let realmStorage = self?.realmStorage else { | |
return Disposables.create() | |
guard let realmStorage = self?.realmStorage else { | |
assertionFailure("realm storage is not exist") | |
return Disposables.create() |
π Issue Number
Close #6
π μμ λ΄μ
μ Storageλ λ€μκ³Ό κ°μ ꡬ쑰λ₯Ό κ°μ§λ€.
/Data
π μμ μ ν
π 체ν¬λ¦¬μ€νΈ
π PR νΉμ΄ μ¬ν