Feature/quest delete and decrease #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinwoong16
reviewed
Dec 12, 2022
Comment on lines
+13
to
+17
| enum QuestViewType { | ||
| case home | ||
| case friend | ||
| } | ||
|
|
There was a problem hiding this comment.
enum์ผ๋ก ์ฒ๋ฆฌํ์ จ๋ค์. ์ข์ ์ ํ๊ฐ์ต๋๋ค!
Comment on lines
+26
to
+27
| private var itemDidLongClick = PublishSubject<Quest>() | ||
| private var itemDidDeleteClicked: PublishSubject<Quest>! |
There was a problem hiding this comment.
itemDidDeleteClicked๊ฐ ์ต์
๋์ธ ์ด์ ๋ ๋ฌด์์ธ๊ฐ์??
|
๊ณ ์ํ์ จ์ต๋๋น! |
|
๊ณ ์ํ์ จ์ต๋๋ค~~~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Issue Number
Close #144
๐ ์์ ๋ด์ญ
๐ ์์ ์ ํ
๐ ์ฒดํฌ๋ฆฌ์คํธ
๐ PR ํน์ด ์ฌํญ