-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/friend view calendar fetch #149
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b80c33a
[refactor] ์์ฐ๋ FriendCalendarUseCase ์ญ์
wickedRun fc78443
[refactor] FriendCalendarUseCase๊ฐ ์๋ CalendarUseCase๋ก protocol ๋ณ๊ฒฝ ๋ฐ ๊ตฌํ
wickedRun 2bd9661
[refactor] QuestRepository์ ํ๋ฌ ๋ฐ์ดํฐ ๊ฐ์ ธ์ค๋ ๋ฉ์๋ ๋ฆฌํด ํ์
๋ณ๊ฒฝ
wickedRun f5a90fb
[refactor] DefaultQuestRepository์ ํ๋ฌ ๋ฐ์ดํฐ ๊ฐ์ ธ์ค๋ ๋ฉ์๋ ๊ตฌํ
wickedRun d084913
[refactor] FriendCalendarUseCase๋ฅผ CalendarUseCase๋ก ๋ณ๊ฒฝ
wickedRun 6c81402
[refactor] drag ์ ์ค์ณ ๊ตฌํ
wickedRun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ import RxSwift | |
|
||
import RxSwift | ||
|
||
final class DefaultFriendCalendarUseCase: FriendCalendarUseCase { | ||
final class DefaultFriendCalendarUseCase: CalendarUseCase { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ๊ธฐ์กด๊ณผ ๋งฅ๋ฝ์ ๋์ผํ ๋ก์ง์ด๋ผ๋ฉด ๋๋ ค์ฐ๋๊ฒ ์ข๊ธดํ๊ฒ๊ฐ์ต๋๋ค ! |
||
private let user: User | ||
private let questsRepository: QuestsRepository | ||
private let disposeBag = DisposeBag() | ||
|
@@ -27,20 +27,104 @@ final class DefaultFriendCalendarUseCase: FriendCalendarUseCase { | |
|
||
func setupMonths() { | ||
let currentMonth = try? currentMonth.value() | ||
let startDayOfLastMonth = currentMonth?.startDayOfLastMonth | ||
let startDayOfCurrentMonth = currentMonth?.startDayOfCurrentMonth | ||
let startDayOfNextMonth = currentMonth?.startDayOfNextMonth | ||
|
||
let months = [startDayOfLastMonth, startDayOfCurrentMonth, startDayOfNextMonth] | ||
|
||
let months = startDayOfCurrentMonth | ||
|
||
Observable.just(months) | ||
.flatMap(fetchAMontlyCompletion(_:)) | ||
.map { [[], $0, []] } | ||
.bind(to: completionOfMonths) | ||
Observable.from(months) | ||
.concatMap { [weak self] monthDate in | ||
guard let self else { return Observable<[DailyQuestCompletion]>.empty() } | ||
|
||
return self.fetchAMontlyCompletion(monthDate) | ||
} | ||
.toArray() | ||
.subscribe(onSuccess: { [weak self] completionOfMonths in | ||
self?.completionOfMonths.onNext(completionOfMonths) | ||
}) | ||
.disposed(by: disposeBag) | ||
} | ||
|
||
func selectDate(_ date: Date) { | ||
selectedDate.onNext(date) | ||
} | ||
|
||
func fetchNextMontlyCompletion() { | ||
guard let nextMonth = try? currentMonth.value()?.startDayOfNextMonth else { return } | ||
currentMonth.onNext(nextMonth) | ||
|
||
let monthAfterNext = nextMonth.startDayOfNextMonth | ||
|
||
fetchAMontlyCompletion(monthAfterNext) | ||
.subscribe(onNext: { [weak self] monthlyCompletion in | ||
guard | ||
let self, | ||
var values = try? self.completionOfMonths.value() | ||
else { | ||
return | ||
} | ||
|
||
values.removeFirst() | ||
values.append(monthlyCompletion) | ||
|
||
self.completionOfMonths.onNext(values) | ||
}) | ||
.disposed(by: disposeBag) | ||
} | ||
|
||
func fetchLastMontlyCompletion() { | ||
guard let lastMonth = try? currentMonth.value()?.startDayOfLastMonth else { return } | ||
currentMonth.onNext(lastMonth) | ||
|
||
let monthBeforeLast = lastMonth.startDayOfLastMonth | ||
|
||
fetchAMontlyCompletion(monthBeforeLast) | ||
.subscribe(onNext: { [weak self] monthlyCompletion in | ||
guard | ||
let self, | ||
var values = try? self.completionOfMonths.value() | ||
else { | ||
return | ||
} | ||
|
||
values.removeLast() | ||
values.insert(monthlyCompletion, at: 0) | ||
|
||
self.completionOfMonths.onNext(values) | ||
}) | ||
.disposed(by: disposeBag) | ||
} | ||
|
||
func refreshMontlyCompletion(for date: Date) { | ||
guard | ||
let months = try? self.completionOfMonths.value(), | ||
let index = months.firstIndex(where: { month in | ||
month.contains { dailyQuestCompletion in | ||
(dailyQuestCompletion.state != .hidden) | ||
&& (dailyQuestCompletion.day.startOfDay == date.startOfDay) | ||
} | ||
}), | ||
let reloadMonth = months[index].last?.day.startDayOfCurrentMonth | ||
else { | ||
return | ||
} | ||
|
||
fetchAMontlyCompletion(reloadMonth) | ||
.subscribe(onNext: { [weak self] monthlyCompletion in | ||
guard | ||
let self, | ||
var values = try? self.completionOfMonths.value() | ||
else { | ||
return | ||
} | ||
|
||
values[index] = monthlyCompletion | ||
|
||
self.completionOfMonths.onNext(values) | ||
}) | ||
.disposed(by: disposeBag) | ||
} | ||
} | ||
|
||
extension DefaultFriendCalendarUseCase { | ||
|
@@ -62,31 +146,27 @@ extension DefaultFriendCalendarUseCase { | |
private func fetchAMontlyCompletion(_ month: Date?) -> Observable<[DailyQuestCompletion]> { | ||
guard let month = month else { return .empty() } | ||
|
||
return Observable.just(month) | ||
.concatMap { [weak self] date -> Observable<DailyQuestCompletion> in | ||
guard let self else { return Observable.empty() } | ||
|
||
return self.questsRepository | ||
.fetch(by: self.user.uuid, date: date, filter: date) | ||
.asObservable() | ||
.map { quests -> DailyQuestCompletion in | ||
let isSelected = (try? self.selectedDate.value().startOfDay == date) ?? false | ||
|
||
return questsRepository.fetch(by: self.user.uuid, date: month, filter: month) | ||
.map { dict -> [DailyQuestCompletion] in | ||
let completionEndDaysOfLastMonth = month.rangeFromStartWeekdayOfLastMonthToEndDayOfCurrentMonth | ||
.map { date -> DailyQuestCompletion in | ||
return DailyQuestCompletion( | ||
day: date, | ||
state: self.calculateDailyState(quests), | ||
isSelected: isSelected | ||
) | ||
} | ||
} | ||
.toArray() | ||
.map { states in | ||
let firstWeekStates = month.rangeFromStartWeekdayOfLastMonthToEndDayOfCurrentMonth | ||
.map { date -> DailyQuestCompletion in | ||
return DailyQuestCompletion(day: date, state: .hidden, isSelected: false) | ||
state: .hidden, | ||
isSelected: false) | ||
} | ||
|
||
return firstWeekStates + states | ||
let completionOfMonths = dict.keys.sorted().map { date -> DailyQuestCompletion in | ||
let state = self.calculateDailyState(dict[date] ?? []) | ||
let isSelected = (try? self.selectedDate.value().startOfDay == date) ?? false | ||
|
||
return DailyQuestCompletion( | ||
day: date, | ||
state: state, | ||
isSelected: isSelected) | ||
} | ||
|
||
return completionEndDaysOfLastMonth + completionOfMonths | ||
} | ||
.asObservable() | ||
} | ||
|
19 changes: 0 additions & 19 deletions
19
DailyQuest/DailyQuest/Domain/UseCases/Common/Protocols/FriendCalendarUseCase.swift
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ด๋ถ๋ถ ์ฐธ๊ณ ํด์, DI Container ๋ณ๊ฒฝ๋๋ ๋ถ๋ถ์ ์ฒ๋ฆฌํด์ผ๊ฒ ์ต๋๋ค. ๊ณ ์ํ์ จ์ต๋๋ค!