Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/message bubble #37

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Feature/message bubble #37

merged 4 commits into from
Nov 23, 2022

Conversation

jinwoong16
Copy link
Collaborator

๐Ÿ“• Issue Number

Close #36

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • Status์— ์‚ฌ์šฉํ•  ๋ฉ”์„ธ์ง€ ๋ฒ„๋ธ”์ž…๋‹ˆ๋‹ค.
  • UIBezierPath๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ UILabel์„ ์ƒˆ๋กœ์ด ๊ตฌ์„ฑํ•˜์˜€์Šต๋‹ˆ๋‹ค.
    Screenshot 2022-11-22 at 2 11 59 PM

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?
  • ์ƒˆ๋กœ์šด ํ…Œ์ŠคํŠธ์™€ ๊ธฐ์กด์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์— ๋Œ€ํ•ด ๋งŒ์กฑํ•˜๋Š”๊ฐ€?

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

  • ๋ฉ”์„ธ์ง€์˜ ๊ธธ์ด์— ๋”ฐ๋ผ ๋ฉ”์„ธ์ง€ ๋ฒ„๋ธ”ํฌ๊ธฐ๊ฐ€ ๋ณ€๊ฒฝ์ด ๋˜์–ด์•ผ ํ•  ๊ฒƒ ๊ฐ™์•„์„œ UILabel์„ subclassingํ•˜์—ฌ ์ž‘์„ฑํ•˜์˜€์Šต๋‹ˆ๋‹ค. drawText(in:)์•ˆ์˜ ๋ฉ”์„œ๋“œ๊ฐ€ ํ•ต์‹ฌ์ธ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.



@Jeonhui
Copy link
Member

Jeonhui commented Nov 22, 2022

Bezier Path ์ด์šฉํ•ด์„œ ๋งŒ๋“œ์…จ๋„ค์š” ์ €๋„ drawText๋ž‘ Bezier Path ๊ณต๋ถ€ ํ•ด๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค ๊ณ ์ƒํ•˜์…จ์–ด์š”๐Ÿ™ƒ

@jinwoong16
Copy link
Collaborator Author

ํšŒ๊ณ ์‹œ๊ฐ„์— PR์˜ฌ๋ ธ๋‹คํ• ๋žฌ๋Š”๋ฐ, ๋ฒŒ์จ ๋ณด์…จ๋„ค์š” ใ…‹ใ…‹ใ…‹ ๐Ÿ‘

@jinwoong16 jinwoong16 linked an issue Nov 22, 2022 that may be closed by this pull request
2 tasks
@wickedRun
Copy link
Collaborator

์˜ค pr์ด ๋‘๊ฐœ๋กœ ๋‚˜๋‰˜์–ด์ ธ ์žˆ์—ˆ๊ตฐ์š” StatusView์—์„œ ์ž˜๋ดค์๋‹ˆ๋‹ค.

@jinwoong16 jinwoong16 merged commit 3d5e11a into develop Nov 23, 2022
@jinwoong16 jinwoong16 deleted the feature/MessageBubble branch November 23, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message Bubble
3 participants