Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/firebase #52

Merged
merged 20 commits into from
Nov 28, 2022
Merged

Feature/firebase #52

merged 20 commits into from
Nov 28, 2022

Conversation

Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Nov 28, 2022

πŸ“• Issue Number

Close #14

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • Network Service protocol
  • DTO protocol + QuestDTO
  • NetworkError
  • NetworkConfigure
  • FirebaseService
    • func create<T: DTO>(userCase: UserCase, access: Access, dto: T) -> Single

    • func read<T: DTO>(type: T.Type, userCase: UserCase, access: Access, condition: NetworkCondition?) -> Observable

    • func update<T: DTO>(userCase: UserCase, access: Access, dto: T) -> Single

    • func delete<T: DTO>(userCase: UserCase, access: Access, dto: T) -> Single

    • func uploadDataStorage(data: Data, path: StoragePath) -> Single

    • func downloadDataStorage(fileName: String) -> Single

    • func deleteDataStorage(fileName: String) -> Single

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

  • firebase storage에 μ ‘κ·Ό ν•  λ•Œμ— (폴더λͺ…/파일λͺ…)으둜 μ ‘κ·Ό
      • gh:// ~ 경둜λ₯Ό λΆ™μ—¬μ„œ url만 가지고도 접근이 κ°€λŠ₯ν•œλ° μ–΄λ– ν•œ λ°©μ‹μœΌλ‘œ 할지?



Jeonhui and others added 17 commits November 22, 2022 15:39
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
Jeonhui and others added 3 commits November 28, 2022 16:21
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
@Jeonhui Jeonhui merged commit 707ec0f into develop Nov 28, 2022
@Jeonhui Jeonhui deleted the feature/firebase branch November 29, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase
2 participants