Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login view, viewmodel, usecase #55

Merged
merged 12 commits into from
Nov 29, 2022
Merged

Login view, viewmodel, usecase #55

merged 12 commits into from
Nov 29, 2022

Conversation

jinwoong16
Copy link
Collaborator

@jinwoong16 jinwoong16 commented Nov 28, 2022

๐Ÿ“• Issue Number

Close #51 #54

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • UseCase protocol
  • Default use case
  • ViewModel
  • test code
  • Login View Controller

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?
  • ์ƒˆ๋กœ์šด ํ…Œ์ŠคํŠธ์™€ ๊ธฐ์กด์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์— ๋Œ€ํ•ด ๋งŒ์กฑํ•˜๋Š”๊ฐ€?

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

  • ViewController๋ฅผ ์ž‘์„ฑํ•˜์˜€์œผ๋‚˜, viewmodel๊ณผ ์—ฐ๊ฒฐ๋˜์–ด ์žˆ์ง€๋Š” ์•Š์Šต๋‹ˆ๋‹ค. ๋‚ด์ผ ๋ชจ๋“  ๋ ˆ์ด์–ด๋ฅผ ์—ฐ๊ฒฐํ•ด๋ณด๋Š” ๊ณผ์ •์„ ๊ฐ€์ง€๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
  • ๋„ค๋น„๊ฒŒ์ด์…˜๋ฐ”์˜ ๋’ค๋กœ๊ฐ€๊ธฐ ๋ฒ„ํŠผ์˜ ์ƒ‰๊น”์„ ๋ณ€๊ฒฝํ•˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค. Appearance ํŒŒ์ผ์— ํ•ด๋‹น๋‚ด์šฉ์„ ์ถ”๊ฐ€ํ• ๊นŒ ํ–ˆ๋Š”๋ฐ, PR ๋‚ด์šฉ๊ณผ ๋งž๋Š” ๊ฒƒ ๊ฐ™์ง€ ์•Š์•„์„œ ๋”ฐ๋กœ ์ˆ˜์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค :)
  • ์ฒ˜์Œ์— UseCase์ชฝ ๊ฐœ๋ฐœํ•˜๊ณ , view controller๋ฅผ ๋งŒ๋“ค ๋•Œ, ์ž‘์—…ํ•œ ๋‚ด์šฉ๋“ค์ด ํ•„์š”ํ•  ๊ฒƒ ๊ฐ™์•„์„œ ๊ฐ™์€ ๋ธŒ๋žœ์น˜์—์„œ ์ž‘์—…์„ ํ–ˆ๋Š”๋ฐ, ์ง€๊ธˆ๋ณด๋‹ˆ ๋ธŒ๋žœ์น˜๋ฅผ ๋”ฐ๋กœํ•ด์„œ ์ž‘์—…ํ–ˆ์–ด๋„ ๋ฌ์„ ๊ฒƒ ๊ฐ™๋„ค์š”... ๊ทธ๋ž˜์„œ ์ผ๋‹จ issue๋ฅผ 2๊ฐœ ์ƒ์„ฑํ•ด์„œ ์ž‘์—…ํ–ˆ์Šต๋‹ˆ๋‹ค. Login/Logout Viewย #54 ๋ฒˆ ์ด๋ผ๊ณ  ํ‘œ๊ธฐํ•œ ์ปค๋ฐ‹๋ถ€ํ„ฐ 54๋ฒˆ ์ด์Šˆ(LoginView)๋กœ ์—ฐ๊ฒฐ๋˜๋Š” ๋ถ€๋ถ„์ž…๋‹ˆ๋‹ค.



Copy link
Collaborator

@wickedRun wickedRun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!


private let fields: [CommonField] = [
ToggleField(viewModel: .init(title: "๋‘˜๋Ÿฌ๋ณด๊ธฐ ํ—ˆ์šฉ", imageName: "person.crop.circle.badge.checkmark")),
PlainField(viewModel: .init(title: "some", info: "some...?", imageName: "pencil")),
NavigateField(viewModel: .init(title: "๋กœ๊ทธ์ธ", imageName: "person.circle.fill")),
NavigateField(viewModel: .init(title: "๋กœ๊ทธ์ธ", imageName: "person.circle.fill", viewType: .login)),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ ์–ด์ฐจํ”ผ ๊ณ ์ •์ ์ธ ํ•„๋“œ๋“ค์ด๋‹ˆ enum์œผ๋กœ ๊ด€๋ฆฌํ•ด๋„ ๊ดœ์ฐฎ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

@Jeonhui
Copy link
Member

Jeonhui commented Nov 29, 2022

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค ๐Ÿ‘๐Ÿป

@jinwoong16 jinwoong16 merged commit a876af0 into develop Nov 29, 2022
@sprituz
Copy link
Member

sprituz commented Nov 29, 2022

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค !.!

@jinwoong16 jinwoong16 deleted the LoginLogoutUsecase branch November 29, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login/Logout View Login/Logout Use Case
4 participants