Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feture/login logout repository #56

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Conversation

Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Nov 29, 2022

๐Ÿ“• Issue Number

Close #53

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • LogInLogOutRepository

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?
  • ์ƒˆ๋กœ์šด ํ…Œ์ŠคํŠธ์™€ ๊ธฐ์กด์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์— ๋Œ€ํ•ด ๋งŒ์กฑํ•˜๋Š”๊ฐ€?

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 



Jeonhui and others added 2 commits November 28, 2022 16:45
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
Co-Authored-By: Dayeon Lee <43718982+sprituz@users.noreply.github.com>
@jinwoong16 jinwoong16 merged commit c757ff0 into develop Nov 29, 2022
@Jeonhui Jeonhui deleted the feture/LoginLogoutRepository branch November 29, 2022 01:48
@Jeonhui
Copy link
Member Author

Jeonhui commented Nov 29, 2022

์ผ๋‹จ BrowseRepository๊ตฌํ˜„์ฒด์— Realm๋„ ์—ฐ๊ฒฐ์„ ํ•ด๋†“์•˜์Šต๋‹ˆ๋‹ค. ๋‚ด์ผ PR๋‚ ๋ฆดํ…Œ๋‹ˆ BrowseRepoMock ๋ณ€๊ฒฝํ•ด๋„ ๊ดœ์ฐฎ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค๐Ÿ˜Š

  • refactor/RealmStorage ๋ธŒ๋žœ์น˜๋ฅผ ํŒŒ์„œ ์ˆ˜์ •ํ•ด์•ผํ•  ์‚ฌํ•ญ์ด ๋ช‡ ๊ฐ€์ง€ ์žˆ๋Š”๋ฐ ๋‚ด์ผ ์•„์นจ์— ๋ง์”€๋“œ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login/Logout Repository
2 participants