Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/connect login layer #58

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Conversation

jinwoong16
Copy link
Collaborator

๐Ÿ“• Issue Number

Close #57

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • ์ด์ „์— ์ž‘์„ฑ๋œ ๋ชจ๋“  ๋ ˆ์ด์–ด๋ฅผ ์—ฐ๊ฒฐํ•ฉ๋‹ˆ๋‹ค.
  • DI์— ๊ด€๋ จ ๋‚ด์šฉ์„ ์ถ”๊ฐ€ ๊ตฌํ˜„
  • view์™€ viewmodel์„ ๋ฐ”์ธ๋“œ

Screenshot 2022-11-29 at 11 27 19 AM

์œ ํšจํ•˜์ง€ ์•Š์€ ์ด๋ฉ”์ผ๊ณผ ํŒจ์Šค์›Œ๋“œ๋ฅผ ๋‘๋ฒˆ ์ž…๋ ฅํ›„, ์œ ํšจํ•œ ์ด๋ฉ”์ผ๊ณผ ํŒจ์Šค์›Œ๋“œ๋ฅผ ์ž…๋ ฅํ–ˆ์„ ๋•Œ์˜ ๊ฒฐ๊ณผ

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?
  • ์ƒˆ๋กœ์šด ํ…Œ์ŠคํŠธ์™€ ๊ธฐ์กด์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์— ๋Œ€ํ•ด ๋งŒ์กฑํ•˜๋Š”๊ฐ€?

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

  • ์•„์ง ๋กœ๊ทธ์•„์›ƒ ๊ธฐ๋Šฅ์ด ์—†์–ด์„œ ํ•œ๋ฒˆ ๋กœ๊ทธ์ธํ•˜๋ฉด ๊ณ„์† ๋กœ๊ทธ์ธ๋œ ์ƒํƒœ์ผ ๋“ฏ ํ•ฉ๋‹ˆ๋‹ค. ๋กœ๊ทธ์•„์›ƒ ๋กœ์ง์ด ๊ฒฐ์ •์ด ๋๋‚˜๋Š”๋Œ€๋กœ ๋ฐ”๋กœ ์ถ”๊ฐ€๋กœ ๋ฆฌํŒฉํ„ฐํ• ๊ฒŒ์š”.


@wickedRun
Copy link
Collaborator

wickedRun commented Nov 29, 2022

ํ˜น์‹œ setup์—์„œ bind ํ˜ธ์ถœ ์•ˆํ•ด์ฃผ๋Š” ํŠน๋ณ„ํ•œ ์ด์œ ๊ฐ€ ์žˆ๋‚˜์—ฌ?
๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@jinwoong16
Copy link
Collaborator Author

ํ˜น์‹œ setup์—์„œ bind ํ˜ธ์ถœ ์•ˆํ•ด์ฃผ๋Š” ํŠน๋ณ„ํ•œ ์ด์œ ๊ฐ€ ์žˆ๋‚˜์—ฌ? ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

LoginViewController์˜ setup(with:)๋ฅผ ๋ง์”€ํ•˜์‹œ๋Š” ๊ฑฐ๋ผ๋ฉด, ๊ทธ๊ฒƒ์€ ViewController๋ฅผ viewmodel๊ณผ ์—ฐ๊ฒฐ์‹œํ‚ค๊ธฐ์œ„ํ•œ ๋ฉ”์„œ๋“œ์ž…๋‹ˆ๋‹ค.
๋ฐ”์ธ๋“œ๋Š” ํ•˜๋‹จ์˜ extension์œผ๋กœ bind()๋ฉ”์„œ๋“œ๋ฅผ ์‚ฌ์šฉํ•ด์„œ ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค.
์ •๋ฆฌํ•˜๋ฉด, setup(with:)์€ DI์—์„œ ViewController๋ฅผ ๋งŒ๋“ค ๋•Œ, ํ˜ธ์ถœํ•˜๋Š” ๋ฉ”์„œ๋“œ์ธ create(with:)์•ˆ์—์„œ ์‚ฌ์šฉ๋˜๊ณ ,
bind()์€ viewDidLoad()๋ฉ”์„œ๋“œ์—์„œ ์‹คํ–‰๋ฉ๋‹ˆ๋‹ค!

@wickedRun
Copy link
Collaborator

์•„ ๊ทธ QuestView์—๋Š” setup ์•ˆ์— bind ํ•จ์ˆ˜ ํ˜ธ์ถœํ•˜๊ธธ๋ž˜ ํŠน๋ณ„ํ•œ ์ด์œ ๊ฐ€ ์žˆ๋‚˜ ํ–ˆ์Šต๋‹ˆ๋‹น ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค.

@jinwoong16
Copy link
Collaborator Author

viewcontroller์—์„œ๋Š” ๋งˆ์น˜ create(with:)๊ฐ€ init ์—ญํ• ์„ ํ•ด์ฃผ๋Š” ๋Š๋‚Œ์ธ๋ฐ, ์„œ๋ธŒ๋ทฐ๋กœ ์กด์žฌํ•˜๋Š” QuestView๋Š” ๊ทธ๋Ÿฐ๊ฒŒ ์—†์–ด์„œ... setup(with:)ํ•˜๋ฉด์„œ bind๋ฅผ ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋ฆฌํŒฉํ„ฐํ•  ๋•Œ ์ˆ˜์ •ํ•  ์ˆ˜ ์žˆ๋‹ค๋ฉด ํ•ด์•ผ๊ฒ ๋„ค์š” :)

@Jeonhui
Copy link
Member

Jeonhui commented Nov 29, 2022

AuthViewModel์„ LoginViewModel๋กœ ๋ฐ”๊พธ์…จ๋„ค์š”. ์•„๋งˆ SignUp View๋„ ๋”ฐ๋กœ ๋งŒ๋“œ์‹ค ์ƒ๊ฐ์ด์‹  ๊ฒƒ ๊ฐ™์•„์„œ ๋‚ด์ผ ๊ฐ™์ด ์–˜๊ธฐํ•ด๋ณด๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”! ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค๐Ÿ˜ƒ

@jinwoong16 jinwoong16 merged commit 4c8ae2b into develop Nov 30, 2022
@jinwoong16 jinwoong16 deleted the feature/ConnectLoginLayer branch November 30, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoginView ๋ชจ๋“  ๋ ˆ์ด์–ด ์—ฐ๊ฒฐ
3 participants