Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/browse use case, viewModel #63

Merged
merged 17 commits into from
Nov 30, 2022
Merged

Conversation

jinwoong16
Copy link
Collaborator

@jinwoong16 jinwoong16 commented Nov 29, 2022

πŸ“• Issue Number

Close #59 #61

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • Browse Use Case ν”„λ‘œν† μ½œμ„ μž‘μ„±
  • UseCase κ΅¬ν˜„μ²΄ μž‘μ„±
  • ViewModel μž‘μ„±
  • ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

  • Browseμ—μ„œ 각 cell듀이 μœ μ €μ˜ ν”„λ‘œν•„ 이미지λ₯Ό 보여주어야 ν•˜κΈ°μ— BrowseQuest μ—”ν‹°ν‹°μ˜ ν˜•νƒœκ°€ μ•„λž˜μ™€ 같이 λ³€κ²½λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
/// before
struct BrowseQuest {
    let uuid: UUID
    let nickName: String
    let quests: [Quest]
}

/// after
struct BrowseQuest {
    let user: User
    let quests: [Quest]
}



@jinwoong16 jinwoong16 linked an issue Nov 29, 2022 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@wickedRun wickedRun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쒋은 것 κ°™μŠ΅λ‹ˆλ‹€ κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!


import RxSwift

protocol BrowseUseCase {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UseCaseκΉŒμ§€ protocol둜 λ§Œλ“œμ‹  μ΄μœ κ°€ κΆκΈˆν•©λ‹ˆλ‹Ή

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ˜μ‘΄μ„±κ΄€λ¦¬μ— μžˆμ–΄μ„œ κ΅¬ν˜„μ²΄μ— μ˜μ‘΄ν•˜κΈ° λ³΄λ‹€λŠ” μ΅œλŒ€ν•œ μΆ”μƒν™”λœ 그것에 μ˜μ‘΄ν•˜κ²Œ ν•˜κΈ° μœ„ν•΄μ„œμž…λ‹ˆλ‹€. λ ˆν¬μ§€ν† λ¦¬λ„ μ΄λŸ¬ν•œ λ§₯락이라고 μƒκ°ν•΄μš”! 그리고 view model을 μž‘μ„±ν•˜λŠ” μ‹œμ μ—μ„œλ„ μƒκ°ν•˜κΈ°κ°€ 더 νŽΈν•  것이라 μƒκ°ν•©λ‹ˆλ‹€. viewmodelμ—μ„œ 무엇을 λ„£μœΌλ©΄(input) 무엇이 λ‚˜μ˜¬μ§€(output)에 κ΄€ν•΄μ„œλ§Œ 생각할 수 μžˆμ–΄μ„œμš” :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음 κ·Έλ ‡κ΅°μš© μ €λŠ” repositoryλŠ” Use Case μͺ½μœΌλ‘œ μ˜μ‘΄μ„±μ„ ν–₯ν•΄μ•Όν•œλ‹€κ³  μƒκ°ν•΄μ„œ κ·Έκ±°λ₯Ό ν•΄κ²°ν•˜κΈ° μœ„ν•΄ repositoryλŠ” protocol둜 κ΅¬ν˜„ν•œλ‹€κ³  μƒκ°ν–ˆμŠ΅λ‹ˆλ‹€.
κ·Έλž˜μ„œ viewμͺ½μ—μ„œλŠ” μ˜μ‘΄μ„±μ΄ λ‹Ήμ—°νžˆ Use Case둜 ν–₯ν•΄μ„œ ν•„μš”μ—†λ‹€κ³  μƒκ°ν–ˆμŠ΅λ‹ˆλ‹€.
λ‹΅λ³€ν•΄μ£Όμ…”μ„œ κ°μ‚¬ν•¨λ‹ˆλ‹Ή

@jinwoong16 jinwoong16 merged commit 5d38779 into develop Nov 30, 2022
@jinwoong16 jinwoong16 deleted the feature/BrowseUseCase branch November 30, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browse ViewModel Browse Usecase
2 participants