Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/firebase #65

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Refactor/firebase #65

merged 4 commits into from
Nov 30, 2022

Conversation

Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Nov 29, 2022

πŸ“• Issue Number

Close #62

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • FirebaseSerivce ν•˜λ“œ μ½”λ”© μ‚­μ œ
  • NetworkCondition -> NetworkDateFilter 이름 λ³€κ²½
  • uid Type νƒ€μž… λ³€κ²½ String? -> BehaviorRelay<String?>
  • needConditionError -> needFilterError 이름 λ³€κ²½

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

@Jeonhui Jeonhui self-assigned this Nov 29, 2022
@wickedRun
Copy link
Collaborator

wickedRun commented Nov 29, 2022 •
edited
Loading

μ’‹λ„€μš© κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

@jinwoong16
Copy link
Collaborator

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€! 이제 μ € 릴레이λ₯Ό μ‚¬μš©ν•΄μ„œ settings viewμ•ˆμ˜ λ‘œκ·ΈμΈλ²„νŠΌμ„ 둜그인으둜 보일지 λ‘œκ·Έμ•„μ›ƒμœΌλ‘œ 보일지 κ²°μ •ν•˜λ©΄ 될 것 κ°™λ„€μš”. μ•„λ§ˆ AuthRepo에 κ΄€λ ¨ λ‚΄μš©μ„ μΆ”κ°€ν•˜λ©΄ 될 것 같은데, 내일 같이 μ΄μ•ΌκΈ°ν•΄λ΄…μ‹œλ‹€ :)

@jinwoong16 jinwoong16 merged commit 93a9a00 into develop Nov 30, 2022
@Jeonhui Jeonhui deleted the refactor/firebase branch November 30, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jeonhui Jeonhui

Labels
refactor λ¦¬λ·°μš”μ²­ 전희
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor Firebase
3 participants
@Jeonhui @wickedRun @jinwoong16