Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enroll view #68

Merged
merged 6 commits into from
Dec 1, 2022
Merged

Feature/enroll view #68

merged 6 commits into from
Dec 1, 2022

Conversation

jinwoong16
Copy link
Collaborator

πŸ“• Issue Number

Close #64

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • EnrollViewController κ΅¬ν˜„
  • λ‚ μ§œ(μ‹œμž‘λ‚ , λλ‚˜λŠ”λ‚ )λ₯Ό μ„ νƒν•˜λŠ” view κ΅¬ν˜„
  • μš”μΌμ„ μ„ νƒν•˜λŠ” view κ΅¬ν˜„
  • λͺ©ν‘œλŸ‰μ„ μ„€μ •ν•˜λŠ” view κ΅¬ν˜„

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

private func bind() {
        let taps = buttons.enumerated().map { index, button in
            button.rx.tap.map { _ in index }
        }
        
        Observable.from(taps).merge()
            .withUnretained(self)
            .subscribe(onNext: { (owner, value) in
                owner.selectedDay[value]?.toggle()
                owner.selectedDayObservable.accept(owner.selectedDay)
                
                guard let isSelected = owner.selectedDay[value] else { return }
                if isSelected {
                    owner.buttons[value].configuration?.baseBackgroundColor = .maxYellow
                } else {
                    owner.buttons[value].configuration?.baseBackgroundColor = .maxLightYellow
                }
            })
            .disposed(by: disposableBag)
}
  • ν˜„μž¬ μš”μΌμ„ μ„ νƒν•˜λŠ” view의 ꡬ성이 νŠΉμ΄ν•©λ‹ˆλ‹€. μœ„λŠ” bind() λ©”μ„œλ“œλ₯Ό κ°€μ Έμ˜¨ 것인데, 이뢀뢄이 ν™•μ‹€νžˆ μˆ˜μ •μ΄ ν•„μš”ν•©λ‹ˆλ‹€. μ§€κΈˆμ€ 이뢀뢄은 일단 λ¬΄μ‹œν•΄μ£Όμ…”λ„ 될 것 κ°™μŠ΅λ‹ˆλ‹€. 뷰둜직과 λΉ„μ¦ˆλ‹ˆμŠ€ λ‘œμ§μ„ μ—°κ²°ν•˜λŠ” κ³Όμ •μ—μ„œ λ¦¬νŒ©ν„°λ§μ„ ν•  μ˜ˆμ •μž…λ‹ˆλ‹€.



Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enroll View
1 participant