Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/calendar view #78

Merged
merged 26 commits into from
Dec 6, 2022
Merged

Feature/calendar view #78

merged 26 commits into from
Dec 6, 2022

Conversation

wickedRun
Copy link
Collaborator

πŸ“• Issue Number

Close #12

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • μž‘μ—… λ‚΄μ—­ μž‘μ„±

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

  • 아직 데이터 연결은 ν•˜μ§€ μ•Šμ€ μƒνƒœμž…λ‹ˆλ‹€.



# Conflicts:
#	DailyQuest/DailyQuest.xcodeproj/project.pbxproj
# Conflicts:
#	DailyQuest/DailyQuest.xcodeproj/project.pbxproj
@jinwoong16
Copy link
Collaborator

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€~ ν˜Ήμ‹œ viewmodel이름에 myλ₯Ό 뢙여두신 μ΄μœ κ°€ μžˆλ‚˜μš”??

@wickedRun
Copy link
Collaborator Author

@jinwoong16 λ‹€μ‹œ μ—†μ• μ„œ μ˜¬λ ΈλŠ”λ° λΆ™μ˜€λ˜ μ΄μœ λŠ” 친ꡬ λ·°μ—μ„œ λ­”κ°€ 꼬일까봐 κ·Έλ ‡κ²Œ ν–ˆμ—ˆμŠ΅λ‹ˆλ‹€.

@jinwoong16
Copy link
Collaborator

@wickedRun ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€! 엔딩이 λ‹€κ°€μ˜΄μ΄ λŠκ»΄μ§€λ„€μš© :)

@wickedRun wickedRun added this to the 5주차 개발! milestone Dec 5, 2022

class CalendarView: UIView {

lazy var yearMonthLabel: UILabel = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

privateν‚€μ›Œλ“œλ₯Ό μ»΄ν¬λ„ŒνŠΈλ§ˆλ‹€ 달아주면 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€. final ν‚€μ›Œλ“œμ²˜λŸΌ, μ„±λŠ₯ν–₯상에 도움이 λœλ‹€κ³ ν•΄μš”!
final ν‚€μ›Œλ“œμ™€ κ΄€λ ¨λœ 뢀뢄은 μ—¬κΈ°μ˜ μ‹€ν—˜λΆ€λΆ„μ„ ν™•μΈν•΄μ£Όμ„Έμš”!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

였우.. final μ‘°μ°¨ μ•ˆλ‹¨κ±Έ κΉœλΉ‘ν–ˆλ„€μš” γ… 
λ‹€μŒ pr에선 μˆ˜μ •ν•΄μ„œ μ˜¬λ¦¬κ² μŠ΅λ‹ˆλ‹€.

@jinwoong16 jinwoong16 merged commit 45ecf32 into develop Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar
2 participants