Feature/enroll view model #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 현재는 true, false인지 확인만 합니다... dismiss하는 과정과 뷰 새로고침을 어떻게 처리할지 고민해야할 듯 합니다.
…pwm-2022/iOS03-DailyQuest into feature/EnrollViewModel # Conflicts: # DailyQuest/DailyQuest/Presentation/Home/ViewController/EnrollViewController.swift
Jeonhui
reviewed
Dec 5, 2022
| @@ -17,10 +20,11 @@ final class QuantityView: UIView { | |||
| return titleLabel | |||
| }() | |||
|
|
|||
| private lazy var quantityField: UITextField = { | |||
| private(set) lazy var quantityField: UITextField = { | |||
Jeonhui
reviewed
Dec 5, 2022
| input.quantityDidSet) { title, quantity in | ||
| !title.isEmpty && !quantity.isEmpty | ||
| } | ||
| .asDriver(onErrorJustReturn: false) |
There was a problem hiding this comment.
리팩터때, 시작날과 끝나는날도 저쪽부분에 추가해서 핸들링해야할 것 같아요.
끝나는날이 시작하는날보다 이르면 안되니까..!
|
combineLatest같은 결합 연산자를 되게 잘 사용하셨네요. 저도 더 열심히 공부해봐야겠습니다. |
wickedRun
reviewed
Dec 5, 2022
| var date = start | ||
|
|
||
| while date <= end { | ||
| guard let weekday = Calendar(identifier: .gregorian).dateComponents([.weekday], from: date).weekday else { return nil } |
There was a problem hiding this comment.
이부분은 extension 합쳐지면 더 짧게 고쳐질 것 같긴합니당
There was a problem hiding this comment.
refactor 주간에 고쳐봐야겠습니다 :)
| import Foundation | ||
|
|
||
| import RxSwift | ||
| import RxCocoa |
There was a problem hiding this comment.
넵 맞습니다. driver은 RxCocoa에 구현되어있어서요. 하나하나 전부 스케줄러를 지정해서 쓰는것보단 있는거 가져다 쓰는게 좋을 것 같아서요 ㅋㅋㅋ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📕 Issue Number
Close #77
📙 작업 내역
📘 작업 유형
📋 체크리스트
📝 PR 특이 사항
getDates(start:end:weekday:))을 usecase단으로 옮길 생각을 하고 있습니다.