Refactor/quests repository (1) #84
Conversation
| .map { $0.toDomain() } | ||
| .toArray() | ||
| .asObservable() | ||
| .asSingle() |
There was a problem hiding this comment.
asObservable()μμ΄ asSingle()μ μλλμ?
There was a problem hiding this comment.
toArrayλ₯Ό νλ κ²½μ° μλ£νμ΄ λ°λμ΄λ²λ €μ asSingleμ λ°λ‘ μ€νμ΄ μ λμ΄ asObservableλ‘ obseravaleλ‘ λ°κΎΌλ€ singleλ‘ λ°κΎΈμμ΅λλ€ π
There was a problem hiding this comment.
μ κ° μκΈ°λ‘ toArray()μ κ²°κ³Όλ singleμ΄ λλκ±Έλ‘ κΈ°μ΅ν΄μ. (μ ννμ§ μμ§λ§..!)
λ¨Έμ§λλ©΄ νλ²λ μμλ΄μΌκ² λ€μ. λ§μ½ λ§λ€λ©΄ 34,35λ²μ€μ μμ΄λ λ μ§λ..?
There was a problem hiding this comment.
νμΈν΄λ³΄λ κ·Έλ λ€μ. λ°©κΈ κ³ μ³μ 컀λ°ν΄λ¨μ΅λλ€. toArrayμ λ°νκ°μ΄ PrimitiveSequence<SingleTrait, [Quest]>λΌμ κ³ μ³€λκ±΄λ° κ°λ₯νλ€μ κ°μ¬ν©λλ€
There was a problem hiding this comment.
μ¬μ€ Singleμ PrimitiveSequence<SingleTrait, Element>μ νμ
μ리μ΄μ€(typealias)λΌκ³ ν©λλ€!
μ¬κΈ°κΈμ νμΈν΄λ³΄λ©΄ μ’μκ²κ°μμ:)
|
|
||
| import Foundation | ||
|
|
||
| enum DateFilter { |
There was a problem hiding this comment.
μ΄κ² μ°μ monthκ°μ λ°μ΄ν°λ₯Ό κ°μ Έμ¬λ νμνκ²μ΄μ§μ?
κ·Όλ° μμ§μ RealmServiceμλ§ μλ κ²μ΄μ£ ?
π Issue Number
Close #81
π μμ λ΄μ
π μμ μ ν
π 체ν¬λ¦¬μ€νΈ
π PR νΉμ΄ μ¬ν