Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/user repository (2) #85

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Refactor/user repository (2) #85

merged 4 commits into from
Dec 6, 2022

Conversation

Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Dec 5, 2022

πŸ“• Issue Number

Close #82

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • func fetchUser(by uuid: String) -> Observables

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

@Jeonhui Jeonhui added this to the 5주차 개발! milestone Dec 5, 2022
@Jeonhui Jeonhui self-assigned this Dec 5, 2022
@Jeonhui Jeonhui changed the title Refactor/user repository Refactor/user repository (2) Dec 5, 2022
@jinwoong16
Copy link
Collaborator

이전 PRμ—μ„œ μΆ”κ°€λœ 것은 7d19f88 μΈλ“―ν•˜λ„€μš”. λ‹€λ₯ΈλΆ„λ“€ μ°Έκ³ λ°”λžλ‹ˆλ‹€ ~

@jinwoong16 jinwoong16 merged commit 9a1f09f into develop Dec 6, 2022
@Jeonhui Jeonhui deleted the refactor/UserRepository branch December 6, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jeonhui Jeonhui

Labels
feature λ¦¬λ·°μš”μ²­ 전희
Projects
None yet
Milestone
5주차 개발!
Development

Successfully merging this pull request may close these issues.

UserRepository another user info fetch
2 participants
@Jeonhui @jinwoong16