Refactor/data layer (3) #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinwoong16
reviewed
Dec 5, 2022
Comment on lines
+10
to
+15
| final class RepositoryManager { | ||
| static let shared = RepositoryManager() | ||
| private init() { } | ||
|
|
||
| var disposeBag: DisposeBag = DisposeBag() | ||
| } |
There was a problem hiding this comment.
μκ°ν΄λ³΄λ μ΄λ°©μμ μ μν νμκ° μμ λ― ν©λλ€. fetch()λ©μλ λ±μ΄ μ€νλ λλ§λ€ κΈ°μ‘΄μ disposableμ΄ disposeλμ§ μκ³ μλ‘μ΄ disposableμ΄ μμ±λ κ² κ°λ€μ.
There was a problem hiding this comment.
μ΄ λΆλΆμ λν΄μλ μ κ° μ§μμ΄ μ‘°κΈ λΆμ‘±ν κ² κ°λ€μ μ‘°κΈ λ 곡λΆν΄λ³΄κ² μ΅λλ€ π κ°μ¬ν©λλ€
Comment on lines
+36
to
+48
| // // when | ||
| // let output = questViewModel.transform(input: QuestViewModel.Input(viewDidLoad: .just(Date()).asObservable(), itemDidClicked: .just(<#T##element: Quest##Quest#>)), disposeBag: disposeBag) | ||
| // | ||
| // // then | ||
| // output | ||
| // .data | ||
| // .drive(onNext: { quests in | ||
| // print(quests) | ||
| // expectation.fulfill() | ||
| // }) | ||
| // .disposed(by: disposeBag) | ||
| // | ||
| // wait(for: [expectation], timeout: 1) |
There was a problem hiding this comment.
λ³κ²½λ λΆλΆμ λ§κ² ν
μ€νΈ μ½λ μμ ν΄λκ² μ΅λλ€.
ps. test κ΄λ ¨λ 컀λ°μ [test]λΌκ³ λ¬μμ£ΌμΈμ!
wickedRun
reviewed
Dec 5, 2022
|
κ³ μνμ ¨μ΅λλ€!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Issue Number
Close #83
π μμ λ΄μ
π μμ μ ν
π 체ν¬λ¦¬μ€νΈ
π PR νΉμ΄ μ¬ν