Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/friend view #87

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Feature/friend view #87

merged 4 commits into from
Dec 6, 2022

Conversation

jinwoong16
Copy link
Collaborator

๐Ÿ“• Issue Number

Close #80

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • FriendStatusVIew ๊ตฌํ˜„
  • FriendViewController ๊ตฌํ˜„
    • scrollview์™€ stackview ์ถ”๊ฐ€

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?
  • ์ƒˆ๋กœ์šด ํ…Œ์ŠคํŠธ์™€ ๊ธฐ์กด์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์— ๋Œ€ํ•ด ๋งŒ์กฑํ•˜๋Š”๊ฐ€?

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

    
    private lazy var friendStatusView: FriendStatusView = {
        return FriendStatusView()
    }()
    
    /**
     Calendar view goes here.
     */
    
    /**
     Quest view goes here.
     */
    
    // MARK: - Life Cycle
    /**
     property method, `create` goes here.
     */
    
    override func viewDidLoad() {
        super.viewDidLoad()
        
        configureUI()
    }
  • StatusView๋งŒ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ์บ˜๋ฆฐ๋”์™€ ํ€˜์ŠคํŠธ๋ทฐ๊ฐ€ ๋“ค์–ด๊ฐˆ ์ž๋ฆฌ๋Š” ๋งˆ๋ จํ•ด๋‘์—ˆ์Šต๋‹ˆ๋‹ค.
  • ์ด์นœ๊ตฌ์˜ ViewModel์„ ์ƒ์„ฑํ•  ๋•Œ, DIContainer์˜ ์ƒ์„ฑ ๋ฉ”์„œ๋“œ ์ธ์ž๋กœ ์œ ์ € id๋ฅผ ์ฃผ์–ด์„œ viewmodel์„ ์ƒ์„ฑํ•˜๊ฒŒ ํ•˜๋ฉด ํ•ด๋‹น ์œ ์ €์˜ view๋ฅผ ๊ตฌ์„ฑํ•˜๊ฒŒํ•  ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.



@Jeonhui
Copy link
Member

Jeonhui commented Dec 5, 2022

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค.๐Ÿ˜Š home view model ์™„๋ฃŒํ•œ ๋’ค, home view model์ด๋ž‘ ๋น„์Šทํ•˜๊ฒŒ ํ•ด์„œ friend view model ์ ์ ˆํ•˜๊ฒŒ ์—ฐ๊ฒฐ ํ•ด์ฃผ๋ฉด ๋  ๊ฒƒ ๊ฐ™๋„ค์š”

Copy link
Collaborator

@wickedRun wickedRun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค. ๋นจ๋ฆฌ ํ™ˆ๋ทฐ๋ฅผ ์™„์„ฑ์‹œ์ผœ์•ผ๊ฒ ๊ตฐ์š” ใ… 

@sprituz
Copy link
Member

sprituz commented Dec 6, 2022

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค

@jinwoong16 jinwoong16 merged commit 8ce37d9 into develop Dec 6, 2022
@jinwoong16 jinwoong16 deleted the feature/FriendView branch December 6, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FriendViewController
4 participants