Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enroll notify #90

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Feature/enroll notify #90

merged 7 commits into from
Dec 7, 2022

Conversation

jinwoong16
Copy link
Collaborator

πŸ“• Issue Number

Close #89

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • μ™„λ£Œλ²„νŠΌμ„ λˆ„λ₯΄λ©΄ 창이 dismiss
  • μΆ”κ°€λœ ν€˜μŠ€νŠΈκ°€ ν˜„μž¬ λ‚ μ§œμ™€ κ°™λ‹€λ©΄, notification을 톡해 notification emit

Screenshot 2022-12-06 at 4 37 27 PM

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

  • 처음 κ΅¬μƒλŒ€λ‘œ Notification Centerλ₯Ό μ‚¬μš©ν–ˆμŠ΅λ‹ˆλ‹€. refactor주간에 DIContainer μž‘μ—…μ„ ν†΅ν•΄μ„œ μ²˜λ¦¬ν•˜λŠ” 걸둜 ν•΄λ³΄λ €λŠ”λ°... μž˜λ μ§€λŠ” λͺ¨λ₯΄κ² λ„€μš”.
extension DefaultEnrollUseCase: EnrollUseCase {
    func save(with quests: [Quest]) -> Observable<Bool> {
        return questsRepository
            .save(with: quests)
            .map { _ in
                true
            }
            .catchAndReturn(false)
            .do(onSuccess: { _ in
                let today = quests
                    .filter { quest in
                        Calendar.current.isDateInToday(quest.date)
                    }
                if !today.isEmpty {
                    NotificationCenter.default.post(name: .updated, object: Date())
                }
            })
            .asObservable()
    }
}
  • UseCaseμ—μ„œ ν€˜μŠ€νŠΈλ₯Ό λ“±λ‘ν•˜κ³ , 결과에 λ”°λΌμ„œ, 그리고 λ“±λ‘λœ ν€˜μŠ€νŠΈλ“€ 쀑에 μ˜€λŠ˜μ— ν•΄λ‹Ήν•˜λŠ” ν€˜μŠ€λ“œκ°€ μžˆλ‹€λ©΄, 이벀트λ₯Ό λ³΄λ‚΄κ²Œ ν–ˆμŠ΅λ‹ˆλ‹€.



@sprituz
Copy link
Member

sprituz commented Dec 6, 2022

λ‚ μ§œλΆ€λΆ„μ΄λž‘ νšŸμˆ˜λΆ€λΆ„ description이라고 λ˜μ–΄μžˆλŠ”κ²ƒλ§Œ 고치면 μ™„λ²½ν•˜κ² κ΅°μš”

@sprituz
Copy link
Member

sprituz commented Dec 6, 2022

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

@Jeonhui
Copy link
Member

Jeonhui commented Dec 6, 2022

이제 μ§„μ§œ 끝이 점점 λ³΄μ΄λ„€μš” 고생 λ§ŽμœΌμ…¨μ–΄μš”πŸ‘πŸ»

@Jeonhui
Copy link
Member

Jeonhui commented Dec 6, 2022

noti둜 ν•˜μ‹  것도 λ‹€μŒμ£Όλ‚˜ ν”„λ‘œμ νŠΈ λλ‚˜κ³  같이 λ¦¬νŽ™ν† λ§ ν•œ 번 해도 쒋을 것 κ°™μ•„μš” 😎

@wickedRun
Copy link
Collaborator

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€.

@jinwoong16 jinwoong16 merged commit f080bcc into develop Dec 7, 2022
@jinwoong16 jinwoong16 deleted the feature/EnrollNotify branch December 7, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enroll μ™„λ£Œ μ•‘μ…˜
4 participants