Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/quest repository #95

Merged
merged 5 commits into from
Dec 7, 2022
Merged

Fix/quest repository #95

merged 5 commits into from
Dec 7, 2022

Conversation

Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Dec 6, 2022

πŸ“• Issue Number

Close #93

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • DefaultQuestsRepository νŒŒμ΄μ–΄λ² μ΄μŠ€ μ—λŸ¬ 처리 μž‘μ—… 및 μ½”λ“œ μˆ˜μ •
  • DefaultBrowseRepository νŒŒμ΄μ–΄λ² μ΄μŠ€ μ—λŸ¬ 처리 μž‘μ—… 및 μ½”λ“œ μˆ˜μ •
  • DefaultUserRepository νŒŒμ΄μ–΄λ² μ΄μŠ€ μ—λŸ¬ 처리 μž‘μ—… 및 μ½”λ“œ μˆ˜μ •

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

  • μ½”λ“œκ°€ λ­”κ°€ κΉ”λ”ν•˜μ§€ μ•Šμ€ λŠλ‚Œμ΄λ„€μš”

@Jeonhui Jeonhui added this to the 5주차 개발! milestone Dec 6, 2022
@Jeonhui Jeonhui self-assigned this Dec 6, 2022
@jinwoong16
Copy link
Collaborator

μΌκ΄€λ˜κ²Œ μž‘μ„±ν•˜μ…”μ„œ λ¬Έμ œκ°€ λ°œμƒν•΄λ„ λΉ λ₯΄κ²Œ ν•΄κ²°λ˜λŠ” 것 κ°™λ„€μš”! κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€. :)

@sprituz
Copy link
Member

sprituz commented Dec 6, 2022

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

@Jeonhui
Copy link
Member Author

Jeonhui commented Dec 6, 2022

μΌκ΄€λ˜κ²Œ μž‘μ„±ν•˜μ…”μ„œ λ¬Έμ œκ°€ λ°œμƒν•΄λ„ λΉ λ₯΄κ²Œ ν•΄κ²°λ˜λŠ” 것 κ°™λ„€μš”! κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€. :)
μ§„μ›…λ‹˜μ΄ 도움이 많이 λ˜μ–΄μ£Όμ…¨μŠ΅λ‹ˆλ‹€ κ°μ‚¬ν•©λ‹ˆλ‹€ πŸ™‡πŸ»β€β™‚οΈ

@Jeonhui
Copy link
Member Author

Jeonhui commented Dec 6, 2022

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

λ‹€μ—°λ‹˜λ„ 고생이 λ§ŽμœΌμ‹­λ‹ˆλ‹€ 😎

@wickedRun
Copy link
Collaborator

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€. 근데 κΆκΈˆν•œκ²Œ flatMap으둜 해도 realm μ˜΅μ €λ²„λΈ”μ΄ Network μ˜΅μ €λ²„λΈ”λ‘œ λ°”λ€Œμ§€ μ•Šλ‚˜μš”?

@jinwoong16 jinwoong16 merged commit f9da9c5 into develop Dec 7, 2022
@Jeonhui Jeonhui deleted the fix/QuestRepository branch December 7, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jeonhui Jeonhui

Labels
bug Something isn't working λ¦¬λ·°μš”μ²­ 전희
Projects
None yet
Milestone
5주차 개발!
Development

Successfully merging this pull request may close these issues.

fix QuestRepository
4 participants
@Jeonhui @jinwoong16 @sprituz @wickedRun