Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sign up view #96

Merged
merged 27 commits into from
Dec 7, 2022
Merged

Feature/sign up view #96

merged 27 commits into from
Dec 7, 2022

Conversation

Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Dec 6, 2022

πŸ“• Issue Number

Close #94

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • AuthRepository, Use Case SignUp 둜직 μΆ”κ°€
  • SignUpViewContoller & SignUpViewModel
  • LoginView νšŒμ›κ°€μž… λ²„νŠΌ μΆ”κ°€
  • Coordinator Flow μ—°κ²°
  • Firebase νšŒμ›κ°€μž… 쑰건 μΆ”κ°€

둜그인 ν™”λ©΄

스크란샷 2022-12-06 23 23 07

νšŒμ›κ°€μž… ν™”λ©΄

스크란샷 2022-12-06 23 23 10

κ²°κ³Ό (falseλŠ” κΈ€μžμˆ˜ μ œν•œ μ „)

스크란샷 2022-12-06 23 26 51

스크란샷 2022-12-06 23 34 11

λ²„νŠΌ λΉ„ν™œμ„±ν™” κ²°κ³Ό

μž…λ ₯ μ•ˆ ν•œ 경우

스크란샷 2022-12-06 23 39 24

λΉ„λ°€λ²ˆν˜Έ λ‹€λ₯Έ 경우

스크란샷 2022-12-06 23 39 31

@ μœ„μΉ˜κ°€ μ•ˆ λ§žλŠ” 경우

스크란샷 2022-12-06 23 49 02

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

  • νšŒμ›κ°€μž… 성곡 이벀트?
  • νšŒμ›κ°€μž… μ„±κ³΅ν–ˆμ„ 경우 dismiss or toast message



@wickedRun
Copy link
Collaborator

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

@sprituz
Copy link
Member

sprituz commented Dec 7, 2022

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

@jinwoong16 jinwoong16 merged commit d84061a into develop Dec 7, 2022
@Jeonhui Jeonhui deleted the feature/SignUpView branch December 7, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignUpView
4 participants