Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export boost_stacktrace_impl_return_nullptr for static build #186

Merged

Conversation

huangqinjin
Copy link
Contributor

@huangqinjin huangqinjin commented Sep 13, 2024

Now boost_stacktrace.lib provides the symbol boost_stacktrace_impl_return_nullptr for static and shared build.

For header only library, to make the symbol available automatically, the only way AFAIK is to export it. We may also consider provide a configuration macro to opt-out the exported symbol, and user need to manually define the non-exported symbol somewhere in their binaries.

Closes #177 .

@coveralls
Copy link

Coverage Status

coverage: 86.35%. remained the same
when pulling 2feb0fc on huangqinjin:msvc-stacktrace-from-current-exception
into 3f79aee on boostorg:develop.

@apolukhin apolukhin merged commit 464e224 into boostorg:develop Sep 13, 2024
48 checks passed
@apolukhin
Copy link
Member

Many thanks for the PR!

@huangqinjin huangqinjin deleted the msvc-stacktrace-from-current-exception branch September 13, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boost_stacktrace_impl_return_nullptr as an exported symbol
3 participants