#270-2 Fix to remove empty values from release_values #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chang-annie
commented
Aug 26, 2024
| @@ -49,8 +49,8 @@ jobs: | |||
| # replace all whitespaces with newline (required for sort) and then sort all release versions while removing any duplicates | |||
| all_release_versions_sorted=$(echo "${all_release_versions[@]}" | tr ' ' '\n'| sort -u ) | |||
|
|
|||
| # replace the newlines with commas and then remove the trailing comma | |||
| all_release_versions=$(echo "${all_release_versions_sorted[@]}" | tr '\n' ',' | sed 's/,$//') | |||
| # remove any blank rows, replace the newlines with commas, then remove the trailing comma | |||
There was a problem hiding this comment.
I: sed -r '/^\s*$/d' command checks for any rows that only contain whitespace and deletes it
| # replace the newlines with commas and then remove the trailing comma | ||
| all_release_versions=$(echo "${all_release_versions_sorted[@]}" | tr '\n' ',' | sed 's/,$//') | ||
| # remove any blank rows, replace the newlines with commas, then remove the trailing comma | ||
| all_release_versions=$(echo "${all_release_versions_sorted[@]}" | sed -r '/^\s*$/d'| tr '\n' ',' | sed 's/,$//') |
There was a problem hiding this comment.
Q/A: Can you not just use a -z test of release_versions on line 46?
There was a problem hiding this comment.
@ewilkins-csi similar to the -z zero length check, we could use the -n not empty check and loop through the release_versions array
# Iterate over each element in release_versions
for version in "${release_versions[@]}"; do
# Check if the element is not empty
if [ -n "$version" ]; then
# Append the element to all_release_versions
all_release_versions+=("$version")
fi
done
in our case, I think adding the command to remove blank rows at the end is fine since we don't have that many docker images
ewilkins-csi
approved these changes
Aug 26, 2024
chang-annie
deleted the
270-2-adjust-prune-workflow-remove-empty-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to remove any rows that are blank from the
all_release_versionsarray before saving them to output. Without this added logic, if we have any docker images that do not have any release versions, theexclude-tagsparameter gets set to,1.7.0,1.8.0(with an extra comma at the front).