Skip to content

Commit

Permalink
allow examples to link to gtsam_unstable
Browse files Browse the repository at this point in the history
  • Loading branch information
@varunagrawal
varunagrawal committed Nov 7, 2022
1 parent 256c664 commit d57fffb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion examples/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ set (excluded_examples
elaboratePoint2KalmanFilter.cpp
)

gtsamAddExamplesGlob("*.cpp" "${excluded_examples}" "gtsam;${Boost_PROGRAM_OPTIONS_LIBRARY}")
gtsamAddExamplesGlob("*.cpp" "${excluded_examples}" "gtsam;gtsam_unstable;${Boost_PROGRAM_OPTIONS_LIBRARY}")

2 comments on commit d57fffb

@laxnpander
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line causes problems at least under Windows. I have a fresh Windows build with

cmake .. -DGTSAM_BUILD_UNSTABLE 
cmake --build . --config release

and it will crash during linking, because it can not find the unstable lib. It should only link unstable, when unstable is built, no?

@varunagrawal
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have the GTSAM_BUILD_UNSTABLE cmake flag turned off?

Please sign in to comment.