Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail fast in linux matrix #1017

Merged
merged 1 commit into from
Jan 9, 2022
Merged

fail fast in linux matrix #1017

merged 1 commit into from
Jan 9, 2022

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jan 8, 2022

Currently we keep running all Linux CIs even if one failed already. This seems wasteful.

@dellaert dellaert requested a review from ProfFan January 8, 2022 23:30
varunagrawal
varunagrawal approved these changes Jan 8, 2022
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though one thing to think about is getting all the errors to fix, not just one at a time. Though this should be resolved locally fist I guess.

@dellaert dellaert merged commit 76291a7 into develop Jan 9, 2022
@dellaert dellaert deleted the fix/fail_fast branch January 9, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

@ProfFan ProfFan Awaiting requested review from ProfFan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @varunagrawal