added wrapper for ProjectionFactorRollingShutter #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. Can you please add python unit tests as well to ensure the wrapping works as expected? |
|
@varunagrawal sure i will, is there any easy way to check that the tests work locally? what i did now was modify the Dockerfile for ubuntu-gtsam-python with my modified source and new cmake to see that it compiles. but i'm not sure how to run the tests. |
|
You can run |
|
@varunagrawal i added tests for constructors and for the error, i checked it locally and it passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@varunagrawal i added python wrapper for a factor in gtsam_unstable, while i tried to compile and test the wrapper i found out the python wrapper requires cmake>=3.15 since a change you made in December 2021 add POP_FRONT to list which only exists in cmake>=3.15, so i added that to the python wrapper readme, i hope that is ok.