Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two new tests, one with 5 modes #1371

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Two new tests, one with 5 modes #1371

merged 6 commits into from
Jan 5, 2023

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jan 5, 2023

Added two examples;

  • variant of tiny with one mode per measurement
  • variant of switching with one mode per measurement

Also

  • made converting to FG a method, toFactorGraph
  • added sharedMeanAndStddev in GaussianConditional to make BNs easier to create.

Works like a charm - at least ratio tests do.

@dellaert dellaert merged commit c24e975 into develop Jan 5, 2023
@dellaert dellaert deleted the hybrid/multimode branch January 5, 2023 20:00
{GaussianConditional::sharedMeanAndStddev(
Z(i), I_1x1, X(0), Z_1x1, 0.5),
GaussianConditional::sharedMeanAndStddev(
Z(i), I_1x1, X(0), Z_1x1, 3)});
bayesNet.emplaceMixture(gm); // copy :-(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the copy not since that isn't the case any more.

@dellaert dellaert added this to the Hybrid Inference milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants