allow users to use upstream metis, instead of vendored metis #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
reviewed
May 12, 2020
| # this will be added to GTSAM_INCLUDE_DIR by gtsam_extra.cmake.in | ||
| set(GTSAM_METIS_INCLUDE_FOR_INSTALL "include/gtsam/3rdparty/metis/") | ||
|
|
||
| # The actual include directory (for BUILD cmake target interface): |
| @@ -89,7 +89,11 @@ list(APPEND gtsam_srcs "${PROJECT_BINARY_DIR}/config.h" "${PROJECT_BINARY_DIR}/d | |||
| install(FILES "${PROJECT_BINARY_DIR}/config.h" "${PROJECT_BINARY_DIR}/dllexport.h" DESTINATION include/gtsam) | |||
|
|
|||
| if(GTSAM_SUPPORT_NESTED_DISSECTION) | |||
| list(APPEND GTSAM_ADDITIONAL_LIBRARIES metis) | |||
| if(GTSAM_USE_SYSTEM_METIS) | |||
| list(APPEND GTSAM_ADDITIONAL_LIBRARIES ${METIS_LIBRARIES}) | |||
There was a problem hiding this comment.
Hmmm. Can we not make it so that METIS_LIBRARIES points to internal if we use the internal version?
There was a problem hiding this comment.
Yeah I think I can do that.
This was referenced Jun 1, 2020
|
Hey @varunagrawal I'm gonna have to close this PR indefinitely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #220 by allowing the user to use the system metis so as to prevent conflicts from GTSAM's metis and other libraries using the system metis.
Also partially addresses #292
Note: This PR is based on a patch of upstream METIS that has yet to be merged and released in a new METIS version (KarypisLab/METIS#9). Since I went ahead and did this work, I thought I would at least make a PR so that others can see it. When upstream METIS releases a new version, we can then properly merge this in.
This change is