Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved empty to Factor base class. #998

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Moved empty to Factor base class. #998

merged 1 commit into from
Dec 31, 2021

Conversation

dellaert
Copy link
Member

Because it was inconsistently defined, and this one (from Symbolic) seems to works for all Factor types.

@dellaert
Copy link
Member Author

PS needed for DC elimination, @varunagrawal ...

@dellaert dellaert added the quick-review Quick and easy PR to review label Dec 31, 2021
varunagrawal
varunagrawal approved these changes Dec 31, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Simplicity FTW

@dellaert dellaert merged commit 3c9ace6 into develop Dec 31, 2021
@dellaert dellaert deleted the fix/move_empty branch December 31, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @varunagrawal