Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL support in apiserver #204

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

somnusfish
Copy link
Contributor

@somnusfish somnusfish commented Jun 1, 2022

Issue number:
#127

Description of changes:
Add SSL support in API server

* Add a static yamlgen/deploy/cert.yaml file to set up cert-manager
* Update models and build.rs to accommodate certs mounting and deploying
  and adjusting server's port number
* Update apiserver's server and client to use ssl
* Expose 8443 as apiserver port in dockerfile
* Bump SDK to 0.26.0 for openssl dh algorithm and stdio feature

Testing done:

Deployed to cluster and tested the funtionality.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

* Add a static yamlgen/deploy/cert.yaml file to set up cert-manager
* Update models and build.rs to accommodate certs mounting and deploying
  and adjusting server's port number
* Update apiserver's server and client to use ssl
* Expose 8443 as apiserver port in dockerfile
* Bump SDK to 0.26.0 for openssl dh algorithm and stdio feature
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! We will want to modify the readme to provide details on setting up the cert, but the code LGTM.

Copy link

@arnaldo2792 arnaldo2792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think for upcoming releases, it should be possible to keep a few commits independent but still part of your PR, like the SDK bump.

@somnusfish somnusfish merged commit dbcf77f into bottlerocket-os:develop Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants