Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of log level via helm #512

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

cbgbt
Copy link
Contributor

@cbgbt cbgbt commented Aug 9, 2023

Issue number:
Closes #509

Description of changes:
This change allows users to apply tracing filter directives to any of the brupop components.

Filter directives at their most simple act like log-levels; however, you can also apply more complex filters

Testing done:
Ran a brupop cluster with various tracing directives, e.g.

controller_tracing_filter: "hyper=info,debug"
agent_tracing_filter: "warn"
apiserver_tracing_filter: "h2=info,debug"
controller_tracing_filter: "debug"
agent_tracing_filter: "debug"
apiserver_tracing_filter: "debug"

And noted that the log filtering appeared to be correct.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@cbgbt cbgbt merged commit 93d14fe into bottlerocket-os:develop Aug 9, 2023
2 checks passed
@cbgbt cbgbt deleted the log-level branch August 10, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose log-level as configurable via helm
3 participants