Automate helm chart releases #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2023
Merged
cbgbt
force-pushed
the
automatic-helm-releases
branch
from
34b7a7a
to
e667743
Compare
gthao313
approved these changes
Aug 10, 2023
|
Will be cool to have this publishing step automatically triggered! 🪄 Happy to approve once it's clear whether the validation scripts are intentionally not exiting with a failure code. |
cbgbt
force-pushed
the
automatic-helm-releases
branch
from
e667743
to
30845c0
Compare
|
Addressed feedback from @markusboehme. Thanks! |
jpculp
reviewed
Aug 11, 2023
| # the release before that (e.g. v1.2.3-rc3) | ||
| # * If the repository head has advanced from a release tag (e.g. v1.0-g0123abcd), | ||
| # select the release the current head is based on (e.g. v1.0) | ||
| if $(git describe HEAD --tags | grep -Eq "^v[0-9]+(\.[0-9]+)*(-[a-z0-9]+)?$"); then |
There was a problem hiding this comment.
This could also be done with [[ $() =~ ]] if you wanted, but both ways work.
cbgbt
force-pushed
the
automatic-helm-releases
branch
from
30845c0
to
ea41df4
Compare
cbgbt
force-pushed
the
automatic-helm-releases
branch
from
ea41df4
to
b214037
Compare
|
^ Responds to some feedback from @jpculp , and also fixes a few bugs I discovered while reading through the action runner logs. Here's the most recent actions run: With this PR being created: |
jpculp
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #492
Description of changes:
Our current github workflow for publishing charts would create a GitHub release for each new chart, but what we want is for the Releases page to focus on the operator, and for new charts to be available in the helm repository to reflect those.
The eks-charts repo does something like this, so this commit uses a modified version of their workflow to automatically publish charts.
Testing done:
gh-pages: Publish helm charts for v1.3.0 cbgbt/bottlerocket-update-operator#4Limitations
We have to manage our external dependencies on Helm and Kubeconform in the Makefile. Ideally we move these dependencies to the Bottlerocket SDK.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.